Skip to content

Commit d452842

Browse files
author
Yohann Delafollye
committed
Apply suggestions from code review
1 parent c702724 commit d452842

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

cmd/admin.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,7 @@ func runListUsers(c *cli.Context) error {
377377
return err
378378
}
379379

380-
users, err := models.ListUsers()
380+
users, err := models.GetAllUsers()
381381

382382
if err != nil {
383383
return err

models/user.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,10 +236,10 @@ func (u *User) GetEmail() string {
236236
return u.Email
237237
}
238238

239-
// ListUsers returns a slice of all users found in DB.
240-
func ListUsers() ([]*User, error) {
239+
// GetAllUsers returns a slice of all users found in DB.
240+
func GetAllUsers() ([]*User, error) {
241241
users := make([]*User, 0)
242-
return users, x.Find(&users)
242+
return users, x.OrderBy("id").Find(&users)
243243
}
244244

245245
// APIFormat converts a User to api.User

0 commit comments

Comments
 (0)