Add developer warning

kdumontnu · kdumontnu · commit d703297e69ee · 2023-12-31T17:33:56.000-05:00
diff --git a/models/user/user.go b/models/user/user.go
@@ -520,6 +520,8 @@ func GetUserSalt() (string, error) {
 	return hex.EncodeToString(rBytes), nil
 }
 
+// Developer warning: The set of characters here can safely expand without a breaking change,
+// but characters removed from this set can cause user account linking to break
 var invalidUsernameCharsRE = regexp.MustCompile(`[^\w-.]`)
 var removeDiacriticsTransform = transform.Chain(norm.NFD, runes.Remove(runes.In(unicode.Mn)), norm.NFC)
 var removeChars = strings.NewReplacer("'", "")

Original file line number	Diff line number	Diff line change
`@@ -520,6 +520,8 @@ func GetUserSalt() (string, error) {`
`520`	`520`	`return hex.EncodeToString(rBytes), nil`
`521`	`521`	`}`
`522`	`522`
	`523`	`+// Developer warning: The set of characters here can safely expand without a breaking change,`
	`524`	`+// but characters removed from this set can cause user account linking to break`
`523`	`525`	var invalidUsernameCharsRE = regexp.MustCompile(`[^\w-.]`)
`524`	`526`	`var removeDiacriticsTransform = transform.Chain(norm.NFD, runes.Remove(runes.In(unicode.Mn)), norm.NFC)`
`525`	`527`	`var removeChars = strings.NewReplacer("'", "")`