@@ -10,6 +10,8 @@ export default {
10
10
return {
11
11
menuVisible: false ,
12
12
isLoading: false ,
13
+ queryParams: el .getAttribute (' data-queryparams' ),
14
+ issueLink: el .getAttribute (' data-issuelink' ),
13
15
locale: {
14
16
filter_changes_by_commit: el .getAttribute (' data-filter_changes_by_commit' ),
15
17
},
@@ -27,12 +29,6 @@ export default {
27
29
}
28
30
return 0 ;
29
31
},
30
- queryParams() {
31
- return this .$el .parentNode .getAttribute (' data-queryparams' );
32
- },
33
- issueLink() {
34
- return this .$el .parentNode .getAttribute (' data-issuelink' );
35
- },
36
32
},
37
33
mounted() {
38
34
document .body .addEventListener (' click' , this .onBodyClick );
@@ -216,8 +212,8 @@ export default {
216
212
</div >
217
213
<!-- only show the show changes since last review if there is a review AND we are commits ahead of the last review -->
218
214
<div
219
- v-if =" lastReviewCommitSha != null" role = " menuitem "
220
- class =" item"
215
+ v-if =" lastReviewCommitSha != null"
216
+ class =" item" role = " menuitem "
221
217
:class =" {disabled: !commitsSinceLastReview}"
222
218
@keydown.enter =" changesSinceLastReviewClick()"
223
219
@click =" changesSinceLastReviewClick()"
@@ -233,7 +229,7 @@ export default {
233
229
<template v-for =" commit in commits " :key =" commit .id " >
234
230
<div
235
231
class =" item" role =" menuitem"
236
- :class =" {active : commit.selected}"
232
+ :class =" {selected : commit.selected, hovered: commit.hovered }"
237
233
@keydown.enter.exact =" commitClicked(commit.id)"
238
234
@keydown.enter.shift.exact =" commitClickedShift(commit)"
239
235
@mouseover.shift =" highlight(commit)"
@@ -288,6 +284,14 @@ export default {
288
284
border-top : 1px solid var (--color-secondary ) !important ;
289
285
}
290
286
287
+ .ui.dropdown.diff-commit-selector .menu > .item.hovered {
288
+ background-color : var (--color-small-accent );
289
+ }
290
+
291
+ .ui.dropdown.diff-commit-selector .menu > .item.selected {
292
+ background-color : var (--color-accent );
293
+ }
294
+
291
295
.ui.dropdown.diff-commit-selector .menu > .item :focus {
292
296
color : var (--color-text );
293
297
background : var (--color-hover );
0 commit comments