Skip to content

Commit e9cc613

Browse files
authored
Makefile cleanup & double golangci-lint timeout (#14044)
* Makefile cleanup The xmldom dependency is no longer required since #13680. Also, whitespace cleanup. * double the golangci-lint timeout
1 parent f8a668a commit e9cc613

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

Makefile

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
ifeq ($(USE_REPO_TEST_DIR),1)
32

43
# This rule replaces the whole Makefile when we're trying to use /tmp repository temporary files
@@ -697,10 +696,9 @@ generate-license:
697696
generate-gitignore:
698697
GO111MODULE=on $(GO) run build/generate-gitignores.go
699698

700-
701699
.PHONY: generate-images
702700
generate-images:
703-
npm install --no-save --no-package-lock xmldom fabric imagemin-zopfli
701+
npm install --no-save --no-package-lock fabric imagemin-zopfli
704702
node build/generate-images.js
705703

706704
.PHONY: pr\#%
@@ -713,7 +711,7 @@ golangci-lint:
713711
export BINARY="golangci-lint"; \
714712
curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(GOPATH)/bin v1.31.0; \
715713
fi
716-
golangci-lint run --timeout 5m
714+
golangci-lint run --timeout 10m
717715

718716
.PHONY: docker
719717
docker:

0 commit comments

Comments
 (0)