Skip to content

Commit ed6e4f8

Browse files
author
Gusted
committed
Apply feedback
- Also un-comment remove part.
1 parent 37f5359 commit ed6e4f8

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

services/mirror/mirror_push.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,17 +156,17 @@ func runPushSync(ctx context.Context, m *repo_model.PushMirror) error {
156156
}
157157
defer func() {
158158
f.Close()
159-
//if err := os.Remove(f.Name()); err != nil {
160-
// log.Error("os.Remove: %v", err)
161-
//}
159+
if err := os.Remove(f.Name()); err != nil {
160+
log.Error("os.Remove: %v", err)
161+
}
162162
}()
163163

164164
if _, err := f.Write([]byte(m.PrivateKey)); err != nil {
165165
log.Error("f.Write: %v", err)
166166
return errors.New("unexpected error")
167167
}
168168

169-
initArgs = append(initArgs, "-c", fmt.Sprintf("core.sshcommand=ssh -i %s -o IdentitiesOnly=yes", f.Name()))
169+
initArgs = append(initArgs, "-c", fmt.Sprintf("core.sshcommand=ssh -i %q -o IdentitiesOnly=yes", f.Name()))
170170
}
171171
if err := git.Push(ctx, path, git.PushOptions{
172172
Remote: m.RemoteName,

0 commit comments

Comments
 (0)