optmize

wxiaoguang · wxiaoguang · commit ef40ef35f920 · 2024-02-17T13:11:21.000+08:00
diff --git a/modules/setting/oauth2.go b/modules/setting/oauth2.go
@@ -167,7 +167,9 @@ func GetGeneralTokenSigningSecret() []byte {
 		}
 		if generalSigningSecret.CompareAndSwap(old, &jwtSecret) {
 			log.Warn("OAuth2 is not enabled, unable to use a persistent signing secret, a new one is generated, which is not persistent between restarts and cluster nodes")
+			return jwtSecret
 		}
+		return *generalSigningSecret.Load()
 	}
-	return *generalSigningSecret.Load()
+	return *old
 }

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,9 @@ func GetGeneralTokenSigningSecret() []byte {`
`167`	`167`	`}`
`168`	`168`	`if generalSigningSecret.CompareAndSwap(old, &jwtSecret) {`
`169`	`169`	`log.Warn("OAuth2 is not enabled, unable to use a persistent signing secret, a new one is generated, which is not persistent between restarts and cluster nodes")`
	`170`	`+ return jwtSecret`
`170`	`171`	`}`
	`172`	`+ return *generalSigningSecret.Load()`
`171`	`173`	`}`
`172`		`- return *generalSigningSecret.Load()`
	`174`	`+ return *old`
`173`	`175`	`}`