Completely fix task-list checkbox styling (#10798)

zeripath · web-flow · commit f036de5a9470 · 2020-03-22T22:25:38.000Z
Continuing on from #10668 this PR makes goldmark apply the task-list styling to task-lists.
diff --git a/modules/markup/markdown/goldmark.go b/modules/markup/markdown/goldmark.go
@@ -82,6 +82,12 @@ func (g *GiteaASTTransformer) Transform(node *ast.Document, reader text.Reader,
 				link = []byte("#user-content-" + string(link)[1:])
 			}
 			v.Destination = link
+		case *ast.List:
+			if v.HasChildren() && v.FirstChild().HasChildren() && v.FirstChild().FirstChild().HasChildren() {
+				if _, ok := v.FirstChild().FirstChild().FirstChild().(*east.TaskCheckBox); ok {
+					v.SetAttributeString("class", "task-list")
+				}
+			}
 		}
 		return ast.WalkContinue, nil
 	})

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,12 @@ func (g GiteaASTTransformer) Transform(node ast.Document, reader text.Reader,`
`82`	`82`	`link = []byte("#user-content-" + string(link)[1:])`
`83`	`83`	`}`
`84`	`84`	`v.Destination = link`
	`85`	`+ case *ast.List:`
	`86`	`+ if v.HasChildren() && v.FirstChild().HasChildren() && v.FirstChild().FirstChild().HasChildren() {`
	`87`	`+ if _, ok := v.FirstChild().FirstChild().FirstChild().(*east.TaskCheckBox); ok {`
	`88`	`+ v.SetAttributeString("class", "task-list")`
	`89`	`+ }`
	`90`	`+ }`
`85`	`91`	`}`
`86`	`92`	`return ast.WalkContinue, nil`
`87`	`93`	`})`