Fix typo and http status code

Author: lunny

integrations/api_repo_archive_test.go

@@ -48,5 +48,5 @@ func TestAPIDownloadArchive(t *testing.T) {
 
 	link, _ = url.Parse(fmt.Sprintf("/api/v1/repos/%s/%s/archive/master", user2.Name, repo.Name))
 	link.RawQuery = url.Values{"token": {token}}.Encode()
-	MakeRequest(t, NewRequest(t, "GET", link.String()), 400)
+	MakeRequest(t, NewRequest(t, "GET", link.String()), http.StatusBadRequest)
 }

routers/web/repo/repo.go

@@ -373,7 +373,7 @@ func Download(ctx *context.Context) {
 	uri := ctx.Params("*")
 	aReq, err := archiver_service.NewRequest(ctx.Repo.Repository.ID, ctx.Repo.GitRepo, uri)
 	if err != nil {
-		if errors.Is(err, archiver_service.ErrUnknowArchiveFormat{}) {
+		if errors.Is(err, archiver_service.ErrUnknownArchiveFormat{}) {
 			ctx.Error(http.StatusBadRequest, err.Error())
 		} else {
 			ctx.ServerError("archiver_service.NewRequest", err)

services/archiver/archiver.go

@@ -39,19 +39,19 @@ type ArchiveRequest struct {
 // the way to 64.
 var shaRegex = regexp.MustCompile(`^[0-9a-f]{4,64}$`)
 
-// ErrUnknowArchiveFormat request archive format is not supported
-type ErrUnknowArchiveFormat struct {
+// ErrUnknownArchiveFormat request archive format is not supported
+type ErrUnknownArchiveFormat struct {
 	RequestFormat string
 }
 
 // Error implements error
-func (err ErrUnknowArchiveFormat) Error() string {
+func (err ErrUnknownArchiveFormat) Error() string {
 	return fmt.Sprintf("unknown format: %s", err.RequestFormat)
 }
 
 // Is implements error
-func (ErrUnknowArchiveFormat) Is(err error) bool {
-	_, ok := err.(ErrUnknowArchiveFormat)
+func (ErrUnknownArchiveFormat) Is(err error) bool {
+	_, ok := err.(ErrUnknownArchiveFormat)
 	return ok
 }
 
@@ -75,7 +75,7 @@ func NewRequest(repoID int64, repo *git.Repository, uri string) (*ArchiveRequest
 		ext = ".bundle"
 		r.Type = git.BUNDLE
 	default:
-		return nil, ErrUnknowArchiveFormat{RequestFormat: uri}
+		return nil, ErrUnknownArchiveFormat{RequestFormat: uri}
 	}
 
 	r.refName = strings.TrimSuffix(uri, ext)

services/archiver/archiver_test.go

@@ -127,7 +127,7 @@ func TestArchive_Basic(t *testing.T) {
 	assert.NotEqual(t, zipReq.GetArchiveName(), secondReq.GetArchiveName())
 }
 
-func TestErrUnknowArchiveFormat(t *testing.T) {
-	var err = ErrUnknowArchiveFormat{RequestFormat: "master"}
-	assert.True(t, errors.Is(err, ErrUnknowArchiveFormat{}))
+func TestErrUnknownArchiveFormat(t *testing.T) {
+	var err = ErrUnknownArchiveFormat{RequestFormat: "master"}
+	assert.True(t, errors.Is(err, ErrUnknownArchiveFormat{}))
 }