Skip to content

Commit f93a1b2

Browse files
committed
illustrate CR issue
1 parent 1626c14 commit f93a1b2

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

templates/repo/editor/edit.tmpl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,11 @@
3838
data-url="{{.Repository.Link}}/markup"
3939
data-context="{{.RepoLink}}"
4040
data-previewable-extensions="{{.PreviewableExtensions}}"
41-
data-line-wrap-extensions="{{.LineWrapExtensions}}"></textarea>
41+
data-value="{{.FileContent}}"
42+
data="{{.FileContent}}"
43+
data-foo="{{.FileContent}}"
44+
data-line-wrap-extensions="{{.LineWrapExtensions}}">{{.FileContent}}</textarea>
4245
<div class="editor-loading is-loading"></div>
43-
<script>window.monacoContent = "{{.FileContent}}";</script>
4446
</div>
4547
<div class="ui bottom attached tab segment markup" data-tab="preview">
4648
{{.locale.Tr "loading"}}

web_src/js/features/codeeditor.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -105,18 +105,17 @@ export async function createMonaco(textarea, filename, editorOpts) {
105105
monaco.languages.register({id: 'vs.editor.nullLanguage'});
106106
monaco.languages.setLanguageConfiguration('vs.editor.nullLanguage', {});
107107

108-
// TODO: there must be a better way to preserve CRLF in the template rendering
109-
const value = window.monacoContent || '';
110-
delete window.monacoContent;
111-
textarea.value = value;
112-
113108
const editor = monaco.editor.create(container, {
114-
value,
109+
value: textarea.value,
115110
theme: 'gitea',
116111
language,
117112
...other,
118113
});
119114

115+
console.log(JSON.stringify(textarea.value));
116+
console.log(JSON.stringify(textarea.getAttribute('data')));
117+
console.log(JSON.stringify(textarea.getAttribute('data-foo')));
118+
120119
const model = editor.getModel();
121120

122121
// Monaco performs auto-detection of dominant EOL in the file, biased towards LF for

0 commit comments

Comments
 (0)