support reviewing on a deleted file path (#5880)

adelowo · lunny · commit f9d4bd53e6ac · 2019-02-01T09:37:20.000+08:00
diff --git a/models/issue_comment.go b/models/issue_comment.go
@@ -873,10 +873,11 @@ func CreateCodeComment(doer *User, repo *Repository, issue *Issue, content, tree
 	// No need for get commit for base branch changes
 	if line > 0 {
 		commit, err := gitRepo.LineBlame(pr.GetGitRefName(), gitRepo.Path, treePath, uint(line))
-		if err != nil {
+		if err == nil {
+			commitID = commit.ID.String()
+		} else if err != nil && !strings.Contains(err.Error(), "exit status 128 - fatal: no such path") {
 			return nil, fmt.Errorf("LineBlame[%s, %s, %s, %d]: %v", pr.GetGitRefName(), gitRepo.Path, treePath, line, err)
 		}
-		commitID = commit.ID.String()
 	}
 
 	// Only fetch diff if comment is review comment

Original file line number	Diff line number	Diff line change
`@@ -873,10 +873,11 @@ func CreateCodeComment(doer User, repo Repository, issue *Issue, content, tree`
`873`	`873`	`// No need for get commit for base branch changes`
`874`	`874`	`if line > 0 {`
`875`	`875`	`commit, err := gitRepo.LineBlame(pr.GetGitRefName(), gitRepo.Path, treePath, uint(line))`
`876`		`- if err != nil {`
	`876`	`+ if err == nil {`
	`877`	`+ commitID = commit.ID.String()`
	`878`	`+ } else if err != nil && !strings.Contains(err.Error(), "exit status 128 - fatal: no such path") {`
`877`	`879`	`return nil, fmt.Errorf("LineBlame[%s, %s, %s, %d]: %v", pr.GetGitRefName(), gitRepo.Path, treePath, line, err)`
`878`	`880`	`}`
`879`		`- commitID = commit.ID.String()`
`880`	`881`	`}`
`881`	`882`
`882`	`883`	`// Only fetch diff if comment is review comment`