Skip to content

Commit f9f2c16

Browse files
authored
bug: fix assignees double load bug (#10856)
Because the assigness has been loaded in compare.go 416: RetrieveRepoMetas(ctx, ctx.Repo.Repository, true) then issue.go 381 RetrieveRepoMilestonesAndAssignees(ctx, repo) then issue.go 361 -- 365 , they are load assignees So the code on compare.go 425 -- 427 is double work, and which is the reason of #10853 Signed-off-by: a1012112796 <[email protected]>
1 parent 828a27f commit f9f2c16

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

routers/repo/compare.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -422,10 +422,6 @@ func CompareDiff(ctx *context.Context) {
422422
beforeCommitID := ctx.Data["BeforeCommitID"].(string)
423423
afterCommitID := ctx.Data["AfterCommitID"].(string)
424424

425-
if ctx.Data["Assignees"], err = ctx.Repo.Repository.GetAssignees(); err != nil {
426-
ctx.ServerError("GetAssignees", err)
427-
return
428-
}
429425

430426
ctx.Data["Title"] = "Comparing " + base.ShortSha(beforeCommitID) + "..." + base.ShortSha(afterCommitID)
431427

0 commit comments

Comments
 (0)