get rule by id after getting rule by name failed

Author: Zettat123

routers/web/repo/setting_protected_branch.go

@@ -165,8 +165,13 @@ func SettingsProtectedBranchPost(ctx *context.Context) {
 		return
 	}
 
-	if f.RuleID > 0 {
-		var err error
+	var err error
+	protectBranch, err = git_model.GetProtectedBranchRuleByName(ctx, ctx.Repo.Repository.ID, f.RuleName)
+	if err != nil {
+		ctx.ServerError("GetProtectedBranchRuleByName", err)
+		return
+	}
+	if protectBranch == nil && f.RuleID > 0 {
 		protectBranch, err = git_model.GetProtectedBranchRuleByID(ctx, ctx.Repo.Repository.ID, f.RuleID)
 		if err != nil {
 			ctx.ServerError("GetProtectedBranchRuleByID", err)
@@ -245,7 +250,7 @@ func SettingsProtectedBranchPost(ctx *context.Context) {
 	protectBranch.UnprotectedFilePatterns = f.UnprotectedFilePatterns
 	protectBranch.BlockOnOutdatedBranch = f.BlockOnOutdatedBranch
 
-	err := git_model.UpdateProtectBranch(ctx, ctx.Repo.Repository, protectBranch, git_model.WhitelistOptions{
+	err = git_model.UpdateProtectBranch(ctx, ctx.Repo.Repository, protectBranch, git_model.WhitelistOptions{
 		UserIDs:          whitelistUsers,
 		TeamIDs:          whitelistTeams,
 		MergeUserIDs:     mergeWhitelistUsers,