fix

Author: wxiaoguang

modules/appstate/appstate.go

@@ -8,7 +8,6 @@ package appstate
 type StateStore interface {
 	Get(item StateItem) error
 	Set(item StateItem) error
-	Delete(item StateItem) error
 }
 
 // StateItem provides the name for a state item. the name will be used to generate filenames, etc

modules/appstate/file.go

@@ -44,11 +44,6 @@ func (f *FileStore) Set(item StateItem) error {
 	return ioutil.WriteFile(f.genFilePath(item), b, fs.FileMode(0644))
 }
 
-// Delete removes the state item
-func (f *FileStore) Delete(item StateItem) error {
-	return os.Remove(f.genFilePath(item))
-}
-
 // NewFileStore returns a new file store
 func NewFileStore(path string) (*FileStore, error) {
 	_ = os.Mkdir(path, fs.FileMode(0755))

routers/init.go

@@ -74,9 +74,9 @@ func InitGitServices() {
 	mustInit(repository.NewContext)
 }
 
-func syncAppPathForGit(ctx context.Context) (err error) {
+func syncAppPathForGit(ctx context.Context) error {
 	runtimeState := new(appstate.RuntimeState)
-	if err = setting.AppState.Get(runtimeState); err != nil {
+	if err := setting.AppState.Get(runtimeState); err != nil {
 		return err
 	}
 	if runtimeState.LastAppPath != setting.AppPath {