Make switch more clear (#5119)

cristaloleg · lunny · commit fef0410b92cd · 2018-10-19T21:36:41.000+08:00
diff --git a/models/review.go b/models/review.go
@@ -38,12 +38,11 @@ func (rt ReviewType) Icon() string {
 		return "eye"
 	case ReviewTypeReject:
 		return "x"
+	case ReviewTypeComment, ReviewTypeUnknown:
+		return "comment"
 	default:
-	case ReviewTypeComment:
-	case ReviewTypeUnknown:
 		return "comment"
 	}
-	return "comment"
 }
 
 // Review represents collection of code comments giving feedback for a PR

Original file line number	Diff line number	Diff line change
`@@ -38,12 +38,11 @@ func (rt ReviewType) Icon() string {`
`38`	`38`	`return "eye"`
`39`	`39`	`case ReviewTypeReject:`
`40`	`40`	`return "x"`
	`41`	`+ case ReviewTypeComment, ReviewTypeUnknown:`
	`42`	`+ return "comment"`
`41`	`43`	`default:`
`42`		`- case ReviewTypeComment:`
`43`		`- case ReviewTypeUnknown:`
`44`	`44`	`return "comment"`
`45`	`45`	`}`
`46`		`- return "comment"`
`47`	`46`	`}`
`48`	`47`
`49`	`48`	`// Review represents collection of code comments giving feedback for a PR`