Show/link to proper PR on kanban board ref (#15004) #15011
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: {show,link to} proper PR on kanban board ref (go-gitea#15004)
the issue was that PR references in kanban boards were being generated
using `.ID` instead of `.Index`, which led to constructing incorrect
links to possibly non-existent {PR,issue}s and following that to showing
nonsensical values in the boards.
kudos also go to @zeripath for pointing at the file to fix.
Signed-off-by: wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf <[email protected]>
Co-authored-by: zeripath <[email protected]>
jolheiser
changed the title
jolheiser
reviewed
Mar 16, 2021
Comment on lines
128
to
+130
| {{ end }} | ||
| </div> | ||
| {{- end }} |
There was a problem hiding this comment.
I believe in 1.13 this is an extraneous {{end}} tag
GiteaBot
added
the
lgtm/need 2
|
Going to close this per discussion in Discord. This diff points out that a bug never existed in 1.13 (because this template change itself doesn't exist in 1.13) |
|
Appears that this feature wasn't present in 1.13 after all. Therefore this backport is not necessary. Sorry @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf ! |
|
was fun, though 🚀 😆 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #15004
the issue was that PR references in kanban boards were being generated
using
.IDinstead of.Index, which led to constructing incorrectlinks to possibly non-existent {PR,issue}s and following that to showing
nonsensical values in the boards.
kudos also go to @zeripath for pointing at the file to fix.
Signed-off-by: wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf [email protected]
Co-authored-by: zeripath [email protected]