Avoid creating an array for the sole purpose of counting elements #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably speeds up counting commits for git versions < 1.8.0, although I dubt it would make a visible difference
| @@ -142,7 +142,7 @@ func commitsCount(repoPath, revision, relpath string) (int64, error) { | |||
| } | |||
|
|
|||
| if isFallback { | |||
| return int64(len(strings.Split(stdout, "\n"))), nil | |||
| return int64(strings.Count(stdout, "\n")), nil | |||
There was a problem hiding this comment.
Can you verify that the result is actually correct? I guess this will be 1 smaller than the actual.
There was a problem hiding this comment.
You were right.
Now it matches rev-list --count
With format='' the output does not end with a newline (checked)
|
Thanks! |
sapk
pushed a commit
to sapk-fork/git-module
that referenced
this pull request
Mar 8, 2017
Added real name of Bwko to maintainers file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably speeds up counting commits for git versions < 1.8.0,
although I dubt it would make a visible difference