Fixed returning non empty tag list when there are no tags. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapk
pushed a commit
to sapk-fork/git-module
that referenced
this pull request
Mar 8, 2017
Integrated drone and other standard files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #8, when a repo has no tags, then a non empty tag list is returned (
[""]). Reference: gogs/gogs#2880I made this mistake by replacing the previous implementation (
tags[:len(tags)-1]) withstrings.TrimSpace(stdout). This worked fine, then there were tags, but created an invalid list otherwise.This PR fixes this.
Sorry for my mistake!