maintner: removed the cl url generator

Restored the maintner file moving the cl url generator to the gopherbot logic as in the previous version.

Author: Ivan Palladino

cmd/gopherbot/gopherbot.go

@@ -915,7 +915,7 @@ func (b *gopherbot) cl2issue(ctx context.Context) error {
 				// already processed this issue.
 				return nil
 			}
-			prefix := fmt.Sprintf("Change %s", cl.URL().String())
+			prefix := fmt.Sprintf("Change https://golang.org/cl/%d", cl.Number)
 			for _, ref := range cl.GitHubIssueRefs {
 				if id := ref.Repo.ID(); id.Owner != "golang" || id.Repo != "go" {
 					continue

maintner/gerrit.go

@@ -509,16 +509,6 @@ func (cl *GerritCL) CommitAtVersion(version int32) *GitCommit {
 	return cl.Project.commit[hash]
 }
 
-// URL returns the absolute url of the CL.
-func (cl *GerritCL) URL() *url.URL {
-	s := fmt.Sprintf("https://golang.org/cl/%d", cl.Number)
-	u, err := url.Parse(s)
-	if err != nil {
-		return &url.URL{}
-	}
-	return u
-}
-
 func (cl *GerritCL) updateGithubIssueRefs() {
 	gp := cl.Project
 	gerrit := gp.gerrit

maintner/gerrit_test.go

@@ -559,20 +559,3 @@ func TestGerritHashtagsLen(t *testing.T) {
 		}
 	}
 }
-
-func TestGerritURL(t *testing.T) {
-	tests := []struct {
-		set  int32
-		want string
-	}{
-		{0, "https://golang.org/cl/0"},
-		{1238812784, "https://golang.org/cl/1238812784"},
-	}
-	for _, tt := range tests {
-		cl := &GerritCL{Number: tt.set}
-		got := cl.URL().String()
-		if got != tt.want {
-			t.Errorf("For set %d, url = %#v; want %v", tt.set, got, tt.want)
-		}
-	}
-}