Skip to content

Commit afd181c

Browse files
cuonglmgopherbot
authored andcommitted
test,misc: fix builders that do not support plugin
CL 406358 added test that use -buildmode=plugin. But plugin mode only supports on some os/arch pairs, so this CL moving the test to misc/cgo/testplugin directory instead. Updates #52937 Change-Id: Iad049443c1f6539f6af1988bebd4dff56c6e1bf9 Reviewed-on: https://go-review.googlesource.com/c/go/+/406774 Reviewed-by: Michael Knyszek <[email protected]> Run-TryBot: Cuong Manh Le <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Auto-Submit: Cuong Manh Le <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent cc4957a commit afd181c

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

misc/cgo/testplugin/plugin_test.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,10 @@ func TestIssue44956(t *testing.T) {
296296
run(t, "./issue44956.exe")
297297
}
298298

299+
func TestIssue52937(t *testing.T) {
300+
goCmd(t, "build", "-buildmode=plugin", "-o", "issue52937.so", "./issue52937/main.go")
301+
}
302+
299303
func TestForkExec(t *testing.T) {
300304
// Issue 38824: importing the plugin package causes it hang in forkExec on darwin.
301305

test/typeparam/issue52937.go renamed to misc/cgo/testplugin/testdata/issue52937/main.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,3 @@
1-
// build -buildmode=plugin
2-
3-
//go:build !js
4-
// +build !js
5-
61
// Copyright 2022 The Go Authors. All rights reserved.
72
// Use of this source code is governed by a BSD-style
83
// license that can be found in the LICENSE file.

0 commit comments

Comments
 (0)