Skip to content

Commit d839d59

Browse files
committed
fix Damien's comments
1 parent d99dd39 commit d839d59

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

http2/server.go

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2652,7 +2652,7 @@ func checkWriteHeaderCode(code int) {
26522652
// no equivalent bogus thing we can realistically send in HTTP/2,
26532653
// so we'll consistently panic instead and help people find their bugs
26542654
// early. (We can't return an error from WriteHeader even if we wanted to.)
2655-
if code < 100 || code > 999 {
2655+
if code <= 100 || code > 999 {
26562656
panic(fmt.Sprintf("invalid WriteHeader code %v", code))
26572657
}
26582658
}
@@ -2674,11 +2674,8 @@ func (rws *responseWriterState) writeHeader(code int) {
26742674

26752675
// Handle informational headers, except 100 (Continue) which is handled automatically
26762676
if code > 100 && code < 200 {
2677-
var h http.Header
2678-
if code == 103 {
2679-
// Per RFC 8297 we must not clear the current header map
2680-
h = rws.handlerHeader
2681-
}
2677+
// Per RFC 8297 we must not clear the current header map
2678+
h := rws.handlerHeader
26822679

26832680
if rws.conn.writeHeaders(rws.stream, &writeResHeaders{
26842681
streamID: rws.stream.id,
@@ -2689,10 +2686,6 @@ func (rws *responseWriterState) writeHeader(code int) {
26892686
rws.dirty = true
26902687
}
26912688

2692-
if code == 103 {
2693-
rws.bw.Flush()
2694-
}
2695-
26962689
return
26972690
}
26982691

0 commit comments

Comments
 (0)