Skip to content

Commit f8a62e7

Browse files
committed
fix Damien's comments
1 parent dbabe26 commit f8a62e7

File tree

1 file changed

+3
-10
lines changed

1 file changed

+3
-10
lines changed

http2/server.go

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2650,7 +2650,7 @@ func checkWriteHeaderCode(code int) {
26502650
// no equivalent bogus thing we can realistically send in HTTP/2,
26512651
// so we'll consistently panic instead and help people find their bugs
26522652
// early. (We can't return an error from WriteHeader even if we wanted to.)
2653-
if code < 100 || code > 999 {
2653+
if code <= 100 || code > 999 {
26542654
panic(fmt.Sprintf("invalid WriteHeader code %v", code))
26552655
}
26562656
}
@@ -2672,11 +2672,8 @@ func (rws *responseWriterState) writeHeader(code int) {
26722672

26732673
// Handle informational headers, except 100 (Continue) which is handled automatically
26742674
if code > 100 && code < 200 {
2675-
var h http.Header
2676-
if code == 103 {
2677-
// Per RFC 8297 we must not clear the current header map
2678-
h = rws.handlerHeader
2679-
}
2675+
// Per RFC 8297 we must not clear the current header map
2676+
h := rws.handlerHeader
26802677

26812678
if rws.conn.writeHeaders(rws.stream, &writeResHeaders{
26822679
streamID: rws.stream.id,
@@ -2687,10 +2684,6 @@ func (rws *responseWriterState) writeHeader(code int) {
26872684
rws.dirty = true
26882685
}
26892686

2690-
if code == 103 {
2691-
rws.bw.Flush()
2692-
}
2693-
26942687
return
26952688
}
26962689

0 commit comments

Comments
 (0)