Skip to content

Commit 548707d

Browse files
committed
address comments
1 parent 9c1946d commit 548707d

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

unix/mremap_linux_test.go renamed to unix/mremap_test.go

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,13 @@
88
package unix_test
99

1010
import (
11-
"golang.org/x/sys/unix"
1211
"testing"
12+
13+
"golang.org/x/sys/unix"
1314
)
1415

1516
func TestMremap(t *testing.T) {
16-
b, err := unix.Mmap(-1, 0, unix.Getpagesize()*2, unix.PROT_NONE, unix.MAP_ANON|unix.MAP_PRIVATE)
17+
b, err := unix.Mmap(-1, 0, unix.Getpagesize(), unix.PROT_NONE, unix.MAP_ANON|unix.MAP_PRIVATE)
1718
if err != nil {
1819
t.Fatalf("Mmap: %v", err)
1920
}
@@ -22,22 +23,23 @@ func TestMremap(t *testing.T) {
2223
}
2324

2425
b[0] = 42
25-
if err := unix.Msync(b, unix.MS_SYNC); err != nil {
26-
t.Fatalf("Msync: %v", err)
27-
}
2826

29-
bNew, err := unix.Mremap(b, unix.Getpagesize(), unix.MREMAP_MAYMOVE)
27+
bNew, err := unix.Mremap(b, unix.Getpagesize()*2, unix.MREMAP_MAYMOVE)
3028
if err != nil {
3129
t.Fatalf("Mremap2: %v", err)
3230
}
31+
b[unix.Getpagesize()+1] = 84
3332

3433
if bNew[0] != 42 {
3534
t.Fatal("first element value was changed")
3635
}
37-
if len(bNew) != unix.Getpagesize() {
36+
if bNew[unix.Getpagesize()+1] != 84 {
37+
t.Fatalf("element value in new memory space wasn't changed")
38+
}
39+
if len(bNew) != unix.Getpagesize()*2 {
3840
t.Fatal("new memory len not equal to specified len")
3941
}
40-
if cap(bNew) != unix.Getpagesize() {
42+
if cap(bNew) != unix.Getpagesize()*2 {
4143
t.Fatal("new memory cap not equal to specified len")
4244
}
4345
}

0 commit comments

Comments
 (0)