gopls/internal/lsp/cache: address additional comments from CL 553095

These uses of the unnecessarily indirect v.snapshot.view were missed.

Change-Id: I00d464c2fbbb1a73f95fe9f47773b6879a02c56b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/554058
Reviewed-by: Alan Donovan <[email protected]>
Auto-Submit: Alan Donovan <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>

Author: findleyr

gopls/internal/lsp/cache/view.go

@@ -426,8 +426,8 @@ func viewEnv(v *View) string {
 		v.root.Path(),
 		strings.TrimRight(v.folder.Env.GoVersionOutput, "\n"),
 		v.folder.Options.BuildFlags,
-		*v.snapshot.view.folder.Env,
-		v.snapshot.view.envOverlay,
+		*v.folder.Env,
+		v.envOverlay,
 	)
 
 	return buf.String()