Upgrade depguard to fix performance issue with go modules (#698)

* Upgrade depguard to fix performance issue with go modules

* Fix linting error of unused function

Author: Will Dixon

.golangci.yml

@@ -48,6 +48,7 @@ linters:
   enable:
     - bodyclose
     - deadcode
+    - depguard
     - dupl
     - errcheck
     # - funlen - TODO: enable it when golangci.com will support it.
@@ -79,7 +80,6 @@ linters:
     # - whitespace - TODO: enable it when golangci.com will support it.
 
   # don't enable:
-  # - depguard - until https://github.com/OpenPeeDeeP/depguard/issues/7 gets fixed
   # - maligned,prealloc
   # - gochecknoglobals
 

Makefile

@@ -14,9 +14,7 @@ clean:
 .PHONY: fast_build build build_race clean
 
 # Test
-
-# until https://github.com/OpenPeeDeeP/depguard/issues/7 fixed
-test: export GO111MODULE = off
+test: export GO111MODULE = on
 test: export GOLANGCI_LINT_INSTALLED = true
 
 test: build

README.md

@@ -907,6 +907,7 @@ linters:
   enable:
     - bodyclose
     - deadcode
+    - depguard
     - dupl
     - errcheck
     # - funlen - TODO: enable it when golangci.com will support it.
@@ -938,7 +939,6 @@ linters:
     # - whitespace - TODO: enable it when golangci.com will support it.
 
   # don't enable:
-  # - depguard - until https://github.com/OpenPeeDeeP/depguard/issues/7 gets fixed
   # - maligned,prealloc
   # - gochecknoglobals
 

go.mod

@@ -3,13 +3,12 @@ module github.com/golangci/golangci-lint
 go 1.11
 
 require (
-	github.com/OpenPeeDeeP/depguard v1.0.0
+	github.com/OpenPeeDeeP/depguard v1.0.1
 	github.com/StackExchange/wmi v0.0.0-20190523213315-cbe66965904d // indirect
 	github.com/fatih/color v1.7.0
 	github.com/go-critic/go-critic v0.3.5-0.20190904082202-d79a9f0c64db
 	github.com/go-lintpack/lintpack v0.5.2
 	github.com/go-ole/go-ole v1.2.4 // indirect
-	github.com/gobwas/glob v0.2.3 // indirect
 	github.com/golang/mock v1.3.1
 	github.com/golangci/check v0.0.0-20180506172741-cfe4005ccda2
 	github.com/golangci/dupl v0.0.0-20180902072040-3e9179ac440a

go.sum

@@ -2,8 +2,8 @@ cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMT
 github.com/BurntSushi/toml v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
 github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
 github.com/OneOfOne/xxhash v1.2.2/go.mod h1:HSdplMjZKSmBqAxg5vPj2TmRDmfkzw+cTzAElWljhcU=
-github.com/OpenPeeDeeP/depguard v1.0.0 h1:k9QF73nrHT3nPLz3lu6G5s+3Hi8Je36ODr1F5gjAXXM=
-github.com/OpenPeeDeeP/depguard v1.0.0/go.mod h1:7/4sitnI9YlQgTLLk734QlzXT8DuHVnAyztLplQjk+o=
+github.com/OpenPeeDeeP/depguard v1.0.1 h1:VlW4R6jmBIv3/u1JNlawEvJMM4J+dPORPaZasQee8Us=
+github.com/OpenPeeDeeP/depguard v1.0.1/go.mod h1:xsIw86fROiiwelg+jB2uM9PiKihMMmUx/1V+TNhjQvM=
 github.com/StackExchange/wmi v0.0.0-20190523213315-cbe66965904d h1:G0m3OIz70MZUWq3EgK3CesDbo8upS2Vm9/P3FtgI+Jk=
 github.com/StackExchange/wmi v0.0.0-20190523213315-cbe66965904d/go.mod h1:3eOhrUMpNV+6aFIbp5/iudMxNCF27Vw2OZgy4xEx0Fg=
 github.com/alecthomas/template v0.0.0-20160405071501-a0175ee3bccc/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc=

pkg/lint/runner.go

@@ -92,8 +92,6 @@ func NewRunner(astCache *astcache.Cache, cfg *config.Config, log logutils.Log, g
 	}, nil
 }
 
-func someUnusedFunc() {}
-
 type lintRes struct {
 	linter *linter.Config
 	err    error