re-enable kitlog and zap by default

Signed-off-by: Timon Wong <[email protected]>

Author: timonwong

.golangci.reference.yml

@@ -1113,19 +1113,19 @@ linters-settings:
 
   loggercheck:
     # Allow check for the github.com/go-kit/log library.
-    # Default: false
-    kitlog: true
+    # Default: true
+    kitlog: false
     # Allow check for the k8s.io/klog/v2 library.
     # Default: true
     klog: false
     # Allow check for the github.com/go-logr/logr library.
     # Default: true
     logr: false
     # Allow check for the "sugar logger" from go.uber.org/zap library.
-    # Default: false
-    zap: true
+    # Default: true
+    zap: false
     # Require all logging keys to be inlined constant strings
-    # Default false
+    # Default: false
     require-string-key: true
     # List of custom rules to check against, where each rule is a single logger pattern.
     # Default: empty

pkg/config/linters_settings.go

@@ -67,9 +67,10 @@ var defaultLintersSettings = LintersSettings{
 		TabWidth:   1,
 	},
 	LoggerCheck: LoggerCheckSettings{
-		Logr:             true,
+		Kitlog:           true,
 		Klog:             true,
-		Zap:              false,
+		Logr:             true,
+		Zap:              true,
 		RequireStringKey: false,
 		Rules:            nil,
 	},

test/testdata/loggercheck/configs/loggercheck_all.yml

@@ -24,5 +24,5 @@ func ExampleDefaultKlog() {
 func ExampleZapSugarNotChecked() {
 	sugar := zap.NewExample().Sugar()
 	defer sugar.Sync()
-	sugar.Infow("message", "key1", "value1", "key2")
+	sugar.Infow("message", "key1", "value1", "key2") // want `odd number of arguments passed as key-value pairs for logging`
 }

test/testdata/loggercheck/loggercheck_all.go

@@ -4,8 +4,21 @@ package loggercheck
 
 import (
 	kitlog "github.com/go-kit/log"
+	"github.com/go-logr/logr"
+	"go.uber.org/zap"
+	"k8s.io/klog/v2"
 )
 
+func ExampleKitLogOnly_NoLogr() {
+	log := logr.Discard()
+	log.Info("message", "key1", "value1", "key2", "value2", "key3")
+	klog.InfoS("message", "key1")
+
+	sugar := zap.NewExample().Sugar()
+	sugar.Infow("message", "key1", "value1", "key2")
+	sugar.Errorw("error message", "key1")
+}
+
 func ExampleKitLogOnly() {
 	logger := kitlog.NewNopLogger()
 

test/testdata/loggercheck/loggercheck_default.go

@@ -24,5 +24,5 @@ func ExampleLogrlintKlog() {
 func ExampleLogrlintZapSugar() {
 	sugar := zap.NewExample().Sugar()
 	defer sugar.Sync()
-	sugar.Infow("message", "key1", "value1", "key2")
+	sugar.Infow("message", "key1", "value1", "key2") // want `odd number of arguments passed as key-value pairs for logging`
 }