[lldb-dap] fix config value comparison (llvm#142017)

eronnen · google-yfyang · commit 5669cd2c38da · 2025-05-29T18:20:21.000-04:00
Fix TypeSCript comparison (when defining an empty config string like
`commandEscapePrefix=""` it would skip it)
diff --git a/lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts b/lldb/tools/lldb-dap/src-ts/debug-configuration-provider.ts
@@ -84,7 +84,7 @@ export class LLDBDapConfigurationProvider
         continue;
       }
       const value = config.get(key);
-      if (!value || value === cfg.default) {
+      if (value === undefined || value === cfg.default) {
         continue;
       }
       switch (cfg.type) {

Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ export class LLDBDapConfigurationProvider`
`84`	`84`	`continue;`
`85`	`85`	`}`
`86`	`86`	`const value = config.get(key);`
`87`		`- if (!value \|\| value === cfg.default) {`
	`87`	`+ if (value === undefined \|\| value === cfg.default) {`
`88`	`88`	`continue;`
`89`	`89`	`}`
`90`	`90`	`switch (cfg.type) {`