Skip to content

chore: generate non-cloud client library (#1770) #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Feb 24, 2023

  • chore: add proto group prefix

  • add test case for generating google maps

  • run new tests in ci

  • parameterize group id for proto artifacts

  • use helper to compute group id of proto artifacts

  • verify non cloud library generation

  • change artifact name in golden

  • restore new client test

  • change description

  • change description

  • add comments to _proto_group_id
    Source-Link: googleapis/synthtool@269a915
    Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:9bf82029163bc06d58f56682afd1893a42ace3e04b0359accb86f79c6ecdc9f9

* chore: add proto group prefix

* add test case for generating google maps

* run new tests in ci

* parameterize group id for proto artifacts

* use helper to compute group id of proto artifacts

* verify non cloud library generation

* change artifact name in golden

* restore new client test

* change description

* change description

* add comments to _proto_group_id
Source-Link: googleapis/synthtool@269a915
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:9bf82029163bc06d58f56682afd1893a42ace3e04b0359accb86f79c6ecdc9f9
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner February 24, 2023 21:23
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 24, 2023
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Feb 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2023
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: m Pull request size is medium. labels Feb 27, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 27, 2023
@diegomarquezp diegomarquezp merged commit 3cb09eb into main Feb 27, 2023
@diegomarquezp diegomarquezp deleted the owl-bot-update-lock-9bf82029163bc06d58f56682afd1893a42ace3e04b0359accb86f79c6ecdc9f9 branch February 27, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests. owl-bot-update-lock size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants