-
Notifications
You must be signed in to change notification settings - Fork 24
Bug: Catch any underlying exceptions from http.HTTPException #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Oops, commit name doesn't match mine. Will fix later. |
So, |
407cba8
to
1226ee4
Compare
@jonparrott cheers for that. I saw it but seemingly ignored it in a rush to leave. That should now be fixed and I've changed the git user.name to one that should have signed the CLA (afaik). |
LGTM, but you'll need to please travis. |
Resolves https://github.com/GoogleCloudPlatform/google-auth-library- python-httplib2/issues/6
38a44d9
to
eb9d13a
Compare
Travis now passes, you might want to check what I've done though. Rather than adding a unit test for an import error I've just added six to the requirements and fetched through there. Given that pretty much everything that targets 2/3 bundles six anyway it seems like the easiest thing? CLA should pass now (how is it rerun?). |
Thank you, @Poogles! |
Resolves #6