Skip to content

ci: removing Kokoro settings that are covered by GitHub Actions #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 23, 2021

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Feb 22, 2021

The GitHub Actions have been enabled in this repository. I believe we no longer need the Kokoro builds here.


Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@suztomo suztomo requested a review from a team as a code owner February 22, 2021 22:06
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 22, 2021
@suztomo suztomo changed the title ci: removing Kokoro settings in favor of GitHub Actions ci: removing Kokoro settings that are covered by GitHub Actions Feb 22, 2021
Comment on lines 31 to 37
- "units (7)"
- "units (8)"
- "units (11)"
- "windows"
- "linkage-monitor"
- "lint"
- "clirr"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are checks that are already green. The "dependencies" are still red.

Copy link
Collaborator

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clirr is the binary compatibilty check

@suztomo
Copy link
Member Author

suztomo commented Feb 23, 2021

@chingor13 Thank you for the advice. Now all Kokoro lines are removed. I'll merge this once the checks pass.

@suztomo suztomo marked this pull request as ready for review February 23, 2021 21:47
@suztomo suztomo merged commit 20f2bd0 into googleapis:master Feb 23, 2021
@suztomo suztomo deleted the required_checks branch February 23, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants