Skip to content

Commit 4fc2fac

Browse files
feat: Improve client settings (#2097)
* feat: Add necessary client settings to sample * feat: Add keepalive to default setting and also add it to samples * . * . * . * . * . * . * . * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent bcd7fc9 commit 4fc2fac

File tree

3 files changed

+21
-2
lines changed

3 files changed

+21
-2
lines changed

google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/StreamWriter.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,10 @@ static BigQueryWriteSettings getBigQueryWriteSettings(Builder builder) throws IO
318318
new BigQueryWriteSettings.Builder()
319319
.setTransportChannelProvider(
320320
BigQueryWriteSettings.defaultGrpcTransportProviderBuilder()
321-
.setChannelsPerCpu(1)
321+
.setKeepAliveTime(org.threeten.bp.Duration.ofMinutes(1))
322+
.setKeepAliveTimeout(org.threeten.bp.Duration.ofMinutes(1))
323+
.setKeepAliveWithoutCalls(true)
324+
.setChannelsPerCpu(2)
322325
.build())
323326
.setCredentialsProvider(
324327
BigQueryWriteSettings.defaultCredentialsProviderBuilder().build())

google-cloud-bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/StreamWriterTest.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1413,6 +1413,17 @@ public void testBuilderDefaultSetting() throws Exception {
14131413
writeSettings.getCredentialsProvider().toString());
14141414
assertTrue(
14151415
writeSettings.getTransportChannelProvider() instanceof InstantiatingGrpcChannelProvider);
1416+
assertTrue(
1417+
((InstantiatingGrpcChannelProvider) writeSettings.getTransportChannelProvider())
1418+
.getKeepAliveWithoutCalls());
1419+
assertEquals(
1420+
((InstantiatingGrpcChannelProvider) writeSettings.getTransportChannelProvider())
1421+
.getKeepAliveTimeout(),
1422+
org.threeten.bp.Duration.ofMinutes(1));
1423+
assertEquals(
1424+
((InstantiatingGrpcChannelProvider) writeSettings.getTransportChannelProvider())
1425+
.getKeepAliveTime(),
1426+
org.threeten.bp.Duration.ofMinutes(1));
14161427
assertEquals(
14171428
BigQueryWriteSettings.getDefaultEndpoint(), writeSettings.getEndpoint().toString());
14181429
}

samples/snippets/src/main/java/com/example/bigquerystorage/WriteToDefaultStream.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import com.google.api.core.ApiFuture;
2222
import com.google.api.core.ApiFutureCallback;
2323
import com.google.api.core.ApiFutures;
24+
import com.google.api.gax.core.FixedExecutorProvider;
2425
import com.google.cloud.bigquery.BigQuery;
2526
import com.google.cloud.bigquery.BigQueryOptions;
2627
import com.google.cloud.bigquery.QueryJobConfiguration;
@@ -39,6 +40,7 @@
3940
import io.grpc.Status.Code;
4041
import java.io.IOException;
4142
import java.util.Map;
43+
import java.util.concurrent.Executors;
4244
import java.util.concurrent.Phaser;
4345
import java.util.concurrent.atomic.AtomicInteger;
4446
import javax.annotation.concurrent.GuardedBy;
@@ -151,7 +153,10 @@ public void initialize(TableName parentTable)
151153
// For more information about JsonStreamWriter, see:
152154
// https://googleapis.dev/java/google-cloud-bigquerystorage/latest/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.html
153155
streamWriter =
154-
JsonStreamWriter.newBuilder(parentTable.toString(), BigQueryWriteClient.create()).build();
156+
JsonStreamWriter.newBuilder(parentTable.toString(), BigQueryWriteClient.create())
157+
.setExecutorProvider(
158+
FixedExecutorProvider.create(Executors.newScheduledThreadPool(100)))
159+
.build();
155160
}
156161

157162
public void append(AppendContext appendContext)

0 commit comments

Comments
 (0)