Ensure that requestIdCreator is non-null

odeke-em · odeke-em · commit 0340f5422f8e · 2025-05-18T20:43:05.000-07:00
diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionImpl.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionImpl.java
@@ -149,7 +149,7 @@ interface SessionTransaction {
     this.errorHandler = createErrorHandler(spanner.getOptions());
     this.requestIdCreator = requestIdCreator;
     if (this.requestIdCreator == null) {
-      this.requestIdCreator = new XGoogSpannerRequestId.NoopRequestIdCreator();
+      throw new IllegalStateException("requestIdCreator must be non-null");
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ interface SessionTransaction {`
`149`	`149`	`this.errorHandler = createErrorHandler(spanner.getOptions());`
`150`	`150`	`this.requestIdCreator = requestIdCreator;`
`151`	`151`	`if (this.requestIdCreator == null) {`
`152`		`- this.requestIdCreator = new XGoogSpannerRequestId.NoopRequestIdCreator();`
	`152`	`+ throw new IllegalStateException("requestIdCreator must be non-null");`
`153`	`153`	`}`
`154`	`154`	`}`
`155`	`155`