resolve comments

Author: nareshz

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java

@@ -1409,7 +1409,9 @@ public Builder setEnableExtendedTracing(boolean enableExtendedTracing) {
 
     /**
      * Enable spanner server side tracing. Enabling this option will create the trace spans at the
-     * Spanner layer. By default, server side tracing is disabled.
+     * Spanner layer. By default, server side tracing is disabled. Enabling server side tracing
+     * requires OpenTelemetry to be set up properly. Simply enabling this option won't generate
+     * server side traces.
      */
     public Builder enableServerSideTracing() {
       this.enableServerSideTracing = true;
@@ -1515,7 +1517,7 @@ public static void enableOpenCensusTraces() {
   @ObsoleteApi(
       "The OpenCensus project is deprecated. Use enableOpenTelemetryTraces to switch to OpenTelemetry traces")
   @VisibleForTesting
-  public static void resetActiveTracingFramework() {
+  static void resetActiveTracingFramework() {
     activeTracingFramework = null;
   }
 

google-cloud-spanner/src/test/java/com/google/cloud/spanner/SpannerOptionsHelper.java

@@ -0,0 +1,29 @@
+/*
+ * Copyright 2024 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.google.cloud.spanner;
+
+/** Helper to configure SpannerOptions for tests. */
+public class SpannerOptionsHelper {
+
+  /**
+   * Resets the activeTracingFramework. This variable is used for internal testing, and is
+   * not a valid production scenario.
+   */
+  public static void resetActiveTracingFramework() {
+    SpannerOptions.resetActiveTracingFramework();
+  }
+}

google-cloud-spanner/src/test/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpcTest.java

@@ -46,6 +46,7 @@
 import com.google.cloud.spanner.SpannerException;
 import com.google.cloud.spanner.SpannerExceptionFactory;
 import com.google.cloud.spanner.SpannerOptions;
+import com.google.cloud.spanner.SpannerOptionsHelper;
 import com.google.cloud.spanner.SpannerOptions.CallContextConfigurator;
 import com.google.cloud.spanner.Statement;
 import com.google.cloud.spanner.TransactionRunner;
@@ -167,7 +168,7 @@ public static Object[] data() {
   @Before
   public void startServer() throws IOException {
     // Enable OpenTelemetry tracing.
-    SpannerOptions.resetActiveTracingFramework();
+    SpannerOptionsHelper.resetActiveTracingFramework();
     SpannerOptions.enableOpenTelemetryTraces();
 
     assumeTrue(