review comments

surbhigarg92 · surbhigarg92 · commit 1793a56f00be · 2024-11-05T12:23:54.000+05:30
diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerCloudMonitoringExporter.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerCloudMonitoringExporter.java
@@ -141,7 +141,7 @@ private CompletableResultCode exportSpannerClientMetrics(Collection<MetricData>
     // Verifies if metrics data has missing instance id.
     if (!spannerMetricData.stream()
         .flatMap(metricData -> metricData.getData().getPoints().stream())
-        .noneMatch(pd -> SpannerCloudMonitoringExporterUtils.getInstanceId(pd) == null)) {
+        .anyMatch(pd -> SpannerCloudMonitoringExporterUtils.getInstanceId(pd) == null)) {
       logger.log(Level.WARNING, "Metric data has missing instanceId. Skipping export.");
       return CompletableResultCode.ofFailure();
     }

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ private CompletableResultCode exportSpannerClientMetrics(Collection<MetricData>`
`141`	`141`	`// Verifies if metrics data has missing instance id.`
`142`	`142`	`if (!spannerMetricData.stream()`
`143`	`143`	`.flatMap(metricData -> metricData.getData().getPoints().stream())`
`144`		`- .noneMatch(pd -> SpannerCloudMonitoringExporterUtils.getInstanceId(pd) == null)) {`
	`144`	`+ .anyMatch(pd -> SpannerCloudMonitoringExporterUtils.getInstanceId(pd) == null)) {`
`145`	`145`	`logger.log(Level.WARNING, "Metric data has missing instanceId. Skipping export.");`
`146`	`146`	`return CompletableResultCode.ofFailure();`
`147`	`147`	`}`