Skip to content

Commit 3392074

Browse files
committed
chore: remove TODOs
1 parent e03f21b commit 3392074

File tree

1 file changed

+6
-16
lines changed

1 file changed

+6
-16
lines changed

google-cloud-spanner/src/test/java/com/google/cloud/spanner/OpenTelemetryApiTracerTest.java

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -167,19 +167,14 @@ public void testExecuteUpdate() {
167167
assertEquals(CompletableResultCode.ofSuccess(), spanExporter.flush());
168168
List<SpanData> spans = spanExporter.getFinishedSpanItems();
169169
assertContains("CloudSpanner.ReadWriteTransaction", spans);
170-
// TODO: Enable the following line when tracing of update statements in the Java client has
171-
// been added.
172-
// assertContains("CloudSpannerOperation.ExecuteUpdate", spans);
170+
assertContains("CloudSpannerOperation.ExecuteUpdate", spans);
173171
assertContains("CloudSpannerOperation.Commit", spans);
174172
assertContains("Spanner.ExecuteSql", spans);
175173
assertContains("Spanner.Commit", spans);
176174

177-
// TODO: Enable the following line when tracing of update statements in the Java client has
178-
// been added.
179-
// assertParent("CloudSpanner.ReadWriteTransaction", "CloudSpannerOperation.ExecuteUpdate",
180-
// spans);
175+
assertParent("CloudSpanner.ReadWriteTransaction", "CloudSpannerOperation.ExecuteUpdate", spans);
181176
assertParent("CloudSpanner.ReadWriteTransaction", "CloudSpannerOperation.Commit", spans);
182-
assertParent("CloudSpanner.ReadWriteTransaction", "Spanner.ExecuteSql", spans);
177+
assertParent("CloudSpannerOperation.ExecuteUpdate", "Spanner.ExecuteSql", spans);
183178
}
184179

185180
@Test
@@ -194,18 +189,13 @@ public void testBatchUpdate() {
194189
assertEquals(CompletableResultCode.ofSuccess(), spanExporter.flush());
195190
List<SpanData> spans = spanExporter.getFinishedSpanItems();
196191
assertContains("CloudSpanner.ReadWriteTransaction", spans);
197-
// TODO: Enable the following line when tracing of update statements in the Java client has
198-
// been added.
199-
// assertContains("CloudSpannerOperation.BatchUpdate", spans);
192+
assertContains("CloudSpannerOperation.BatchUpdate", spans);
200193
assertContains("CloudSpannerOperation.Commit", spans);
201194
assertContains("Spanner.ExecuteBatchDml", spans);
202195
assertContains("Spanner.Commit", spans);
203-
// TODO: Enable the following line when tracing of update statements in the Java client has
204-
// been added.
205-
// assertParent("CloudSpanner.ReadWriteTransaction", "CloudSpannerOperation.BatchUpdate",
206-
// spans);
196+
assertParent("CloudSpanner.ReadWriteTransaction", "CloudSpannerOperation.BatchUpdate", spans);
207197
assertParent("CloudSpanner.ReadWriteTransaction", "CloudSpannerOperation.Commit", spans);
208-
assertParent("CloudSpanner.ReadWriteTransaction", "Spanner.ExecuteBatchDml", spans);
198+
assertParent("CloudSpannerOperation.BatchUpdate", "Spanner.ExecuteBatchDml", spans);
209199
assertParent("CloudSpannerOperation.Commit", "Spanner.Commit", spans);
210200
}
211201

0 commit comments

Comments
 (0)