review comments

Author: surbhigarg92

google-cloud-spanner/pom.xml

@@ -255,6 +255,24 @@
       <groupId>io.opentelemetry</groupId>
       <artifactId>opentelemetry-context</artifactId>
     </dependency>
+    <dependency>
+      <groupId>io.opentelemetry</groupId>
+      <artifactId>opentelemetry-sdk-common</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>io.opentelemetry</groupId>
+      <artifactId>opentelemetry-sdk-metrics</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>com.google.cloud</groupId>
+      <artifactId>google-cloud-monitoring</artifactId>
+      <version>3.38.0</version>
+    </dependency>
+    <dependency>
+      <groupId>com.google.api.grpc</groupId>
+      <artifactId>proto-google-cloud-monitoring-v3</artifactId>
+      <version>3.38.0</version>
+    </dependency>
     <dependency>
       <groupId>com.google.auth</groupId>
       <artifactId>google-auth-library-oauth2-http</artifactId>
@@ -415,14 +433,6 @@
       <artifactId>opentelemetry-sdk</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>io.opentelemetry</groupId>
-      <artifactId>opentelemetry-sdk-common</artifactId>
-    </dependency>
-    <dependency>
-      <groupId>io.opentelemetry</groupId>
-      <artifactId>opentelemetry-sdk-metrics</artifactId>
-    </dependency>
     <dependency>
       <groupId>io.opentelemetry</groupId>
       <artifactId>opentelemetry-sdk-trace</artifactId>
@@ -433,16 +443,6 @@
       <artifactId>opentelemetry-sdk-testing</artifactId>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>com.google.cloud</groupId>
-      <artifactId>google-cloud-monitoring</artifactId>
-      <version>3.38.0</version>
-    </dependency>
-    <dependency>
-      <groupId>com.google.api.grpc</groupId>
-      <artifactId>proto-google-cloud-monitoring-v3</artifactId>
-      <version>3.38.0</version>
-    </dependency>
   </dependencies>
   <profiles>
     <profile>

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerCloudMonitoringExporter.java

@@ -110,11 +110,11 @@ static SpannerCloudMonitoringExporter create(String projectId, @Nullable Credent
   @Override
   public CompletableResultCode export(Collection<MetricData> collection) {
     if (isShutdown.get()) {
-      logger.log(Level.WARNING, "Exporter is shutting down");
+      logger.log(Level.WARNING, "Exporter is shut down");
       return CompletableResultCode.ofFailure();
     }
 
-    lastExportCode = exportSpannerClientMetrics(collection);
+    this.lastExportCode = exportSpannerClientMetrics(collection);
     return lastExportCode;
   }
 
@@ -131,12 +131,12 @@ private CompletableResultCode exportSpannerClientMetrics(Collection<MetricData>
       return CompletableResultCode.ofSuccess();
     }
 
-    // Verifies metrics project id are the same as the spanner project id set on this client
+    // Verifies metrics project id is the same as the spanner project id set on this client
     if (!spannerMetricData.stream()
         .flatMap(metricData -> metricData.getData().getPoints().stream())
         .allMatch(
             pd -> spannerProjectId.equals(SpannerCloudMonitoringExporterUtils.getProjectId(pd)))) {
-      logger.log(Level.WARNING, "Metric data has different a projectId. Skip exporting.");
+      logger.log(Level.WARNING, "Metric data has a different projectId. Skipping export.");
       return CompletableResultCode.ofFailure();
     }
 
@@ -199,8 +199,7 @@ private ApiFuture<List<Empty>> exportTimeSeriesInBatch(
               .setName(projectName.toString())
               .addAllTimeSeries(batch)
               .build();
-      ApiFuture<Empty> f = this.client.createServiceTimeSeriesCallable().futureCall(req);
-      batchResults.add(f);
+      batchResults.add(this.client.createServiceTimeSeriesCallable().futureCall(req));
     }
 
     return ApiFutures.allAsList(batchResults);

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerCloudMonitoringExporterUtils.java

@@ -60,6 +60,8 @@ class SpannerCloudMonitoringExporterUtils {
   private static final Logger logger =
       Logger.getLogger(SpannerCloudMonitoringExporterUtils.class.getName());
 
+  private SpannerCloudMonitoringExporterUtils() {}
+
   static String getProjectId(PointData pointData) {
     return pointData.getAttributes().get(PROJECT_ID_KEY);
   }