Skip to content

Commit 8796f82

Browse files
committed
add grpc metrics in allowed metrics
1 parent c279a12 commit 8796f82

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

google-cloud-spanner/src/main/java/com/google/cloud/spanner/BuiltInMetricsConstant.java

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import java.util.Map;
3131
import java.util.Set;
3232
import java.util.stream.Collectors;
33+
import java.util.stream.Stream;
3334

3435
@InternalApi
3536
public class BuiltInMetricsConstant {
@@ -46,14 +47,22 @@ public class BuiltInMetricsConstant {
4647
static final String OPERATION_COUNT_NAME = "operation_count";
4748
static final String ATTEMPT_COUNT_NAME = "attempt_count";
4849

50+
static final Collection<String> GRPC_METRICS_TO_ENABLE =
51+
ImmutableList.of(
52+
"grpc.lb.rls.default_target_picks",
53+
"grpc.lb.rls.target_picks",
54+
"grpc.xds_client.server_failure",
55+
"grpc.xds_client.resource_updates_invalid");
56+
4957
public static final Set<String> SPANNER_METRICS =
50-
ImmutableSet.of(
51-
OPERATION_LATENCIES_NAME,
52-
ATTEMPT_LATENCIES_NAME,
53-
OPERATION_COUNT_NAME,
54-
ATTEMPT_COUNT_NAME,
55-
GFE_LATENCIES_NAME)
56-
.stream()
58+
Stream.concat(
59+
Stream.of(
60+
OPERATION_LATENCIES_NAME,
61+
ATTEMPT_LATENCIES_NAME,
62+
OPERATION_COUNT_NAME,
63+
ATTEMPT_COUNT_NAME,
64+
GFE_LATENCIES_NAME),
65+
GRPC_METRICS_TO_ENABLE.stream())
5766
.map(m -> METER_NAME + '/' + m)
5867
.collect(Collectors.toSet());
5968

@@ -111,13 +120,6 @@ public class BuiltInMetricsConstant {
111120
10000.0, 20000.0, 50000.0, 100000.0, 200000.0, 400000.0, 800000.0, 1600000.0,
112121
3200000.0));
113122

114-
static final Collection<String> GRPC_METRICS_TO_ENABLE =
115-
ImmutableList.of(
116-
"grpc.lb.rls.default_target_picks",
117-
"grpc.lb.rls.target_picks",
118-
"grpc.xds_client.server_failure",
119-
"grpc.xds_client.resource_updates_invalid");
120-
121123
static final Collection<String> GRPC_METRICS_ENABLED_BY_DEFAULT =
122124
ImmutableList.of(
123125
"grpc.client.attempt.sent_total_compressed_message_size",

0 commit comments

Comments
 (0)