Skip to content

Commit f76cbc0

Browse files
committed
Address review feedback
1 parent 3c10ee6 commit f76cbc0

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,8 @@ public CommitResponse writeAtLeastOnceWithOptions(
305305
try (IScope s = tracer.withSpan(span)) {
306306
return SpannerRetryHelper.runTxWithRetriesOnAborted(
307307
() -> {
308-
// TODO: Detect an abort and then refresh the reqId.
308+
// TODO(@odeke-em): Only increment on UNAVAILABLE and INCREMENT,
309+
// instead increment the nthRequest on ABORTED and others.
309310
reqId.incrementAttempt();
310311
return new CommitResponse(
311312
spanner.getRpc().commit(request, reqId.withOptions(getOptions())));

0 commit comments

Comments
 (0)