Skip to content

fix: add missing native image test command to build script #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: add missing native image test command to build script #1812

wants to merge 1 commit into from

Conversation

mpeddada1
Copy link
Contributor

No description provided.

@mpeddada1 mpeddada1 requested review from a team as code owners April 9, 2022 00:37
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Apr 9, 2022
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2022
ansh0l
ansh0l approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, adding do not merge label

@ansh0l ansh0l added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 11, 2022
@mpeddada1 mpeddada1 mentioned this pull request Apr 19, 2022
Closed
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2022
@mpeddada1
Copy link
Contributor Author

Thanks for the review @ansh0l and @suztomo! Would it be okay to merge this PR? The Graalvm job is currently not running in the repo so adding this script will help with debugging #1811

@ansh0l
Copy link
Contributor

ansh0l commented May 23, 2022

Closing since native image changes have been released with #1878

@ansh0l ansh0l closed this May 23, 2022
@ansh0l
Copy link
Contributor

ansh0l commented May 23, 2022

Closing since native image changes have been released with #1878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

@ansh0l ansh0l ansh0l approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpeddada1 @ansh0l @suztomo @yoshi-kokoro