Skip to content

test: drop old databases from instance before running integration tests. #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 29, 2022
Merged

test: drop old databases from instance before running integration tests. #1861

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9dc1991
test: drop old databases from instance before running integration tests.
rajatbhatta Apr 28, 2022
b256ee3
fix: linting
rajatbhatta Apr 28, 2022
5c6965f
fix: pass correct instance id.
rajatbhatta Apr 28, 2022
6aa2fd6
test: add logs and catch exception.
rajatbhatta Apr 28, 2022
0523bb2
fix: linting
rajatbhatta Apr 28, 2022
c32efa9
Update google-cloud-spanner/src/test/java/com/google/cloud/spanner/In…
rajatbhatta Apr 29, 2022
4b69330
test: drop only those DBs created through automated tests
rajatbhatta Apr 29, 2022
2e3c9fc
fix: linting
rajatbhatta Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions google-cloud-spanner/src/test/java/com/google/cloud/spanner/IntegrationTestEnv.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,15 @@
import static com.google.common.base.Preconditions.checkState;

import com.google.api.gax.longrunning.OperationFuture;
import com.google.api.gax.paging.Page;
import com.google.cloud.Timestamp;
import com.google.cloud.spanner.testing.EmulatorSpannerHelper;
import com.google.cloud.spanner.testing.RemoteSpannerHelper;
import com.google.common.collect.Iterators;
import com.google.spanner.admin.instance.v1.CreateInstanceMetadata;
import io.grpc.Status;
import java.util.Random;
import java.util.concurrent.TimeUnit;
import java.util.logging.Level;
import java.util.logging.Logger;
import org.junit.rules.ExternalResource;
Expand Down Expand Up @@ -53,6 +56,7 @@ public class IntegrationTestEnv extends ExternalResource {

private TestEnvConfig config;
private InstanceAdminClient instanceAdminClient;
private DatabaseAdminClient databaseAdminClient;
private boolean isOwnedInstance;
private RemoteSpannerHelper testHelper;

Expand Down Expand Up @@ -93,9 +97,12 @@ protected void before() throws Throwable {
}
testHelper = createTestHelper(options, instanceId);
instanceAdminClient = testHelper.getClient().getInstanceAdminClient();
databaseAdminClient = testHelper.getClient().getDatabaseAdminClient();
logger.log(Level.FINE, "Test env endpoint is {0}", options.getHost());
if (isOwnedInstance) {
initializeInstance(instanceId);
} else {
cleanUpOldDatabases(instanceId);
}
}

Expand Down Expand Up @@ -162,6 +169,35 @@ private void initializeInstance(InstanceId instanceId) {
logger.log(Level.INFO, "Created test instance: {0}", createdInstance.getId());
}

private void cleanUpOldDatabases(InstanceId instanceId) {
long OLD_DB_THRESHOLD_SECS = TimeUnit.SECONDS.convert(24L, TimeUnit.HOURS);
Timestamp currentTimestamp = Timestamp.now();
int numDropped = 0;
Page<Database> page = databaseAdminClient.listDatabases(instanceId.getInstance());
String TEST_DB_REGEX = "(testdb_(.*)_(.*))|(mysample-(.*))";

logger.log(Level.INFO, "Dropping old test databases from {0}", instanceId.getName());
while (page != null) {
for (Database db : page.iterateAll()) {
try {
long timeDiff = db.getCreateTime().getSeconds() - currentTimestamp.getSeconds();
// Delete all databases which are more than OLD_DB_THRESHOLD_SECS seconds
// old.
if ((db.getId().getDatabase().matches(TEST_DB_REGEX))
&& (timeDiff > OLD_DB_THRESHOLD_SECS)) {
logger.log(Level.INFO, "Dropping test database {0}", db.getId());
db.drop();
++numDropped;
}
} catch (SpannerException e) {
logger.log(Level.SEVERE, "Failed to drop test database " + db.getId(), e);
}
}
page = page.getNextPage();
}
logger.log(Level.INFO, "Dropped {0} test database(s)", numDropped);
}

private void cleanUpInstance() {
try {
if (isOwnedInstance) {
Expand Down