Skip to content

test: support PostgreSQL dialect for RandomResultsGenerator #1868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2022

Conversation

olavloite
Copy link
Collaborator

Adds support for PostgreSQL dialect to RandomResultsGenerator

Adds support for PostgreSQL dialect to RandomResultsGenerator
@olavloite olavloite requested a review from a team as a code owner May 3, 2022 05:01
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels May 3, 2022
@olavloite olavloite requested review from rajatbhatta and ansh0l May 3, 2022 07:31
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a small query. Please take a look.

@olavloite olavloite merged commit 4f826c5 into main May 4, 2022
@olavloite olavloite deleted the random-results-postgresql branch May 4, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants