chore: Enable requesting numeric enums in "transport=rest" responses for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport #2140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gcf-owl-bot[bot]](https://avatars.githubusercontent.com/in/99011?s=60&v=4){kind=small}
PiperOrigin-RevId: 485623855 Source-Link: googleapis/googleapis@807125e Source-Link: https://github.com/googleapis/googleapis-gen/commit/c4ddd6d651da69658a4762c5eafff5cd8f0e25c5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzRkZGQ2ZDY1MWRhNjk2NThhNDc2MmM1ZWFmZmY1Y2Q4ZjBlMjVjNSJ9
trusted-contributions-gcf
bot
added
kokoro:force-run
product-auto-label
bot
added
size: s
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
trusted-contributions-gcf
bot
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
alicejli
approved these changes
Nov 8, 2022
alicejli
added
the
automerge
alicejli
approved these changes
Nov 8, 2022
gcf-merge-on-green
bot
removed
the
automerge
alicejli
approved these changes
Nov 9, 2022
alicejli
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
diegomarquezp
approved these changes
Nov 17, 2022
diegomarquezp
approved these changes
Nov 18, 2022
diegomarquezp
added
the
automerge
|
Your PR has conflicts that you need to resolve before merge-on-green can automerge |
gcf-merge-on-green
bot
removed
the
automerge
trusted-contributions-gcf
bot
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
|
@googleapis/api-spanner-java Can you take a look at this PR? Thanks! |
…for services supporting this (Java, Go, Python, PHP, TypeScript, C#, and Ruby), even if they do not yet turn on REST transport chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java) PiperOrigin-RevId: 493113566 Source-Link: googleapis/googleapis@758f0d1 Source-Link: https://github.com/googleapis/googleapis-gen/commit/78bd8f05e1276363eb14eae70e91fe4bc20703ab Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzhiZDhmMDVlMTI3NjM2M2ViMTRlYWU3MGU5MWZlNGJjMjA3MDNhYiJ9
gcf-owl-bot
bot
changed the title
rest_numeric_enums = False for all gapic rules explicitly
trusted-contributions-gcf
bot
added
kokoro:force-run
product-auto-label
bot
added
size: m
gcf-owl-bot
bot
removed
the
owlbot:run
trusted-contributions-gcf
bot
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
rajatbhatta
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: disallow "transport=rest" for services where numeric enums are not confirmed to be supported (except in PHP and Java)
PiperOrigin-RevId: 493113566
Source-Link: googleapis/googleapis@758f0d1
Source-Link: https://github.com/googleapis/googleapis-gen/commit/78bd8f05e1276363eb14eae70e91fe4bc20703ab
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzhiZDhmMDVlMTI3NjM2M2ViMTRlYWU3MGU5MWZlNGJjMjA3MDNhYiJ9
BEGIN_NESTED_COMMIT
chore: Set
rest_numeric_enums = Falsefor all gapic rules explicitlyPiperOrigin-RevId: 485623855
Source-Link: googleapis/googleapis@807125e
Source-Link: https://github.com/googleapis/googleapis-gen/commit/c4ddd6d651da69658a4762c5eafff5cd8f0e25c5
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzRkZGQ2ZDY1MWRhNjk2NThhNDc2MmM1ZWFmZmY1Y2Q4ZjBlMjVjNSJ9
END_NESTED_COMMIT