Skip to content

refactor: Removing duplicated code to handle array values #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 7, 2022
Merged

refactor: Removing duplicated code to handle array values #2143

merged 4 commits into from
Dec 7, 2022

Conversation

gauravpurohit06
Copy link
Contributor

@gauravpurohit06 gauravpurohit06 commented Nov 3, 2022 •
edited
Loading

Business logic to decode data types enclosed in an array is duplicated at multiple places which is prone to error and bugs.

@gauravpurohit06
refactor: Removing duplicated code to handle array values
6f029b4 
The same deserialization logic for data types have been duplicated at multiple places which is prone to error.
@gauravpurohit06 gauravpurohit06 requested a review from a team as a code owner November 3, 2022 09:13
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Nov 3, 2022
@gauravpurohit06 gauravpurohit06 added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 3, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 3, 2022
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner November 3, 2022 09:21
olavloite
olavloite reviewed Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant find. I have a couple of questions whether we could make this even more efficient, now that we are looking into this. Would you mind taking a look at that?

@ansh0l ansh0l marked this pull request as draft November 24, 2022 10:47
@gauravpurohit06 gauravpurohit06 marked this pull request as ready for review December 7, 2022 05:38
@gauravpurohit06 gauravpurohit06 mentioned this pull request Dec 7, 2022
Merged
@gauravpurohit06 gauravpurohit06 added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 7, 2022
rajatbhatta
rajatbhatta approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this enhancement!

@gauravpurohit06 gauravpurohit06 merged commit f853918 into googleapis:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansh0l ansh0l ansh0l left review comments

@rajatbhatta rajatbhatta rajatbhatta approved these changes

@olavloite olavloite Awaiting requested review from olavloite

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gauravpurohit06 @olavloite @ansh0l @rajatbhatta