Skip to content

chore: fix kokoro windows java 8 ci by setting JAVA11_HOME env variable #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Dec 28, 2022
Merged

chore: fix kokoro windows java 8 ci by setting JAVA11_HOME env variable #2207

merged 20 commits into from
Dec 28, 2022

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Dec 22, 2022 •
edited
Loading

Related to #2205

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Dec 22, 2022
@mpeddada1
Copy link
Contributor Author

mpeddada1 commented Dec 22, 2022 •
edited
Loading

JAVA11_HOME which is used to compile classes in JDK 11 for GraalVM doesn't appear to be set for the java8-win job

Verify if JAVA11_HOME is set *************

On the other hand, the java8 nightly job which is passing has the JAVA11_HOME env variable set:

Verify if JAVA11_HOME is set *************
/usr/lib/jvm/java-11-openjdk-amd64

@product-auto-label product-auto-label bot removed the size: xs Pull request size is extra small. label Dec 22, 2022
@generated-files-bot
Copy link

generated-files-bot bot commented Dec 22, 2022 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .kokoro/build.bat

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Dec 22, 2022
@mpeddada1
Copy link
Contributor Author 

JAVA11_HOME="/usr/lib/jvm/java-11-openjdk-amd64" (No matching key in allowed env vars)
JAVA8_HOME="/usr/local/openjdk-8" (No matching key in allowed env vars)

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Dec 22, 2022
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Dec 22, 2022
@mpeddada1 mpeddada1 mentioned this pull request Dec 27, 2022
Closed
@mpeddada1
Copy link
Contributor Author

d9eb102 resulted in successful build

@mpeddada1 mpeddada1 marked this pull request as ready for review December 27, 2022 17:50
@mpeddada1 mpeddada1 requested a review from a team as a code owner December 27, 2022 17:50
@mpeddada1 mpeddada1 requested a review from a team as a code owner December 27, 2022 17:50
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Dec 27, 2022
@product-auto-label product-auto-label bot added size: u Pull request is empty. and removed size: xs Pull request size is extra small. labels Dec 27, 2022
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: u Pull request is empty. labels Dec 27, 2022
@mpeddada1 mpeddada1 changed the title chore: verify behavior of kokoro windows java 8 ci chore: fix kokoro windows java 8 ci by setting JAVA11_HOME env variable Dec 27, 2022
rajatbhatta
rajatbhatta approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for working on this, @mpeddada1! :)

@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 27, 2022
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 27, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 27, 2022
@mpeddada1 mpeddada1 merged commit ffa6dfa into main Dec 28, 2022
@mpeddada1 mpeddada1 deleted the fix-java8-win branch December 28, 2022 00:15
@mpeddada1 mpeddada1 mentioned this pull request Dec 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpeddada1 @rajatbhatta @yoshi-kokoro