Skip to content

chore: fix kokoro windows java 8 ci by setting correct JAVA11_HOME #2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

rajatbhatta
Copy link
Contributor

@rajatbhatta rajatbhatta commented Mar 6, 2023

The Windows build was failing due to incorrect JAVA11_HOME env.

Temurin11 has been installed.
  temurin11 may be able to be automatically uninstalled.
Environment Vars (like PATH) have changed. Close/reopen your shell to
 see the changes (or in powershell/cmd.exe just type `refreshenv`).
 The install of temurin11 was successful.
  Software installed to 'C:\Program Files\Eclipse Adoptium\jdk-11.0.18.10-hotspot\'

openjdk11 v11.0.16.20220913 [Approved]
openjdk11 package files install completed. Performing other installation steps.
 The install of openjdk11 was successful.
  Software install location not explicitly set, could be in package or
  default install location if installer.

Chocolatey installed 2/2 packages.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

T:\src>set JAVA11_HOME=C:\Program Files\Eclipse Adoptium\jdk-11.0.17.8-hotspot\

T:\src>"C:\Program Files\Git\bin\bash.exe" T:\src\github\java-spanner\.kokoro\build.sh
/c/ProgramData/chocolatey/lib/maven/apache-maven-3.8.4/bin/mvn: line 92: cd: C:\Program Files\Eclipse Adoptium\jdk-11.0.17.8-hotspot\: No such file or directory
The JAVA_HOME environment variable is not defined correctly,
this environment variable is needed to run this program.

This PR fixes the JAVA11_HOME env to its correct value.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 6, 2023
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/build.bat

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Mar 6, 2023
@rajatbhatta rajatbhatta marked this pull request as ready for review March 6, 2023 16:00
@rajatbhatta rajatbhatta requested review from a team as code owners March 6, 2023 16:00
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 6, 2023
@rajatbhatta rajatbhatta merged commit 0f749dc into main Mar 6, 2023
@rajatbhatta rajatbhatta deleted the windows-fix-java11-home branch March 6, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants