Skip to content

chore(spanner): proto columns files regenerate and test refactor #3115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

harshachinta
Copy link
Contributor

@harshachinta harshachinta commented May 20, 2024

This PR updates the following,

  1. Regenerate SingerProto.java file from singer.proto. This fixes Library Compatibility with Protobuf-Java 4.26.x+ #3113 since the previous files were generated with protoc version of 3.12.x and with this PR it is regenerated with protoc version 3.25.1. Also the .proto is updated to use proto3 syntax.
  2. Remove project level allowlisting on running tests.
  3. Update package name to avoid reserved package error due to name starting with spanner.*

@harshachinta harshachinta requested review from a team as code owners May 20, 2024 10:09
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/java-spanner API. labels May 20, 2024
@harshachinta harshachinta requested a review from rahul2393 May 20, 2024 10:09
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels May 20, 2024
@harshachinta harshachinta changed the title chore(spanner): proto columns files refactoring chore(spanner): proto columns files regenerate and test refactor May 20, 2024
@harshachinta harshachinta added the owlbot:run Add this label to trigger the Owlbot post processor. label May 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 20, 2024
@harshachinta harshachinta merged commit 44abfe1 into googleapis:main May 20, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library Compatibility with Protobuf-Java 4.26.x+
2 participants