Skip to content

test: fail the StatementTimeoutTest if any of the tests are slow #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

olavloite
Copy link
Collaborator

Adds a global timeout that is applied to each of the tests in StatementTimeoutTest. This ensures that if any of the tests are slow, the test case will fail.

Also cleans up some warnings and removes some old-style assertions.

Adds a global timeout that is applied to each of the tests in
StatementTimeoutTest. This ensures that if any of the tests are slow,
the test case will fail.

Also cleans up some warnings and removes some old-style assertions.
@olavloite olavloite requested review from a team as code owners March 13, 2025 10:31
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Mar 13, 2025
@olavloite olavloite merged commit 1b70be0 into main Mar 17, 2025
34 of 35 checks passed
@olavloite olavloite deleted the fail-statement-timeout-test-if-slow branch March 17, 2025 09:14
@suztomo suztomo mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants