Skip to content

fix: allow zero durations to be set for connection properties #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

fix: allow zero durations to be set for connection properties #3916

merged 1 commit into from
Jun 13, 2025

Conversation

olavloite
Copy link
Collaborator

SET statements that set a duration, e.g. max_commit_delay or statement_timeout, did not allow setting a zero duration. This is however sometimes useful, as the server default for max_commit_delay is not zero. This means that setting this to zero triggers a different behavior than not setting a value, as when no value is included in a commit request, Spanner will choose a reasonable value for the commit delay. By explicitly setting it to zero, Spanner will always also use a zero commit delay.

@olavloite olavloite requested review from a team as code owners June 12, 2025 09:29
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. labels Jun 12, 2025
@olavloite olavloite changed the title fix: allow zero durations to be set for connections fix: allow zero durations to be set for connection properties Jun 12, 2025
@olavloite
fix: allow zero durations to be set for connections
4a74a86 
SET statements that set a duration, e.g. max_commit_delay or statement_timeout,
did not allow setting a zero duration. This is however sometimes useful, as the
server default for max_commit_delay is not zero. This means that setting this to
zero triggers a different behavior than not setting a value, as when no value is
included in a commit request, Spanner will choose a reasonable value for the
commit delay. By explicitly setting it to zero, Spanner will always also use a
zero commit delay.
@olavloite olavloite force-pushed the allow-zero-duration branch from b375482 to 4a74a86 Compare June 12, 2025 11:47
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2025
@olavloite olavloite requested a review from aakashanandg June 13, 2025 06:39
@olavloite olavloite merged commit 43ea4fa into main Jun 13, 2025
36 checks passed
@olavloite olavloite deleted the allow-zero-duration branch June 13, 2025 10:07
@release-please release-please bot mentioned this pull request Jun 23, 2025
Merged
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Jun 30, 2025
@github-cash-renovate-jvm-2 @svc-squareup-copybara
This PR contains the following updates:
8714dc2 
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
|
[com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`6.95.1` -> `6.96.0` |
|
[com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`2.29.2` -> `2.30.0` |
|
[com.squareup.okio:okio-fakefilesystem](https://github.com/square/okio)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`3.13.0` -> `3.14.0` |
| [com.squareup.okio:okio](https://github.com/square/okio) |
dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`3.13.0` -> `3.14.0` |
| [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`1.50.0` -> `1.50.1` |
| [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.71` -> `2.31.73` |
| [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.71` -> `2.31.73` |
|
[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.71` -> `2.31.73` |
| [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.71` -> `2.31.73` |
| [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.71` -> `2.31.73` |
| [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.71` -> `2.31.73` |
| [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.31.71` -> `2.31.73` |

---

### Release Notes

<details>
<summary>googleapis/java-spanner
(com.google.cloud:google-cloud-spanner)</summary>

###
[`v6.96.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6960-2025-06-27)

##### Features

- Allow JDBC to configure directpath for connection
([#&#8203;3929](googleapis/java-spanner#3929))
([d754f1f](googleapis/java-spanner@d754f1f))
- Support getOrNull and getOrDefault in Struct
([#&#8203;3914](googleapis/java-spanner#3914))
([1dc5a3e](googleapis/java-spanner@1dc5a3e))
- Use multiplexed sessions for read-only transactions
([#&#8203;3917](googleapis/java-spanner#3917))
([37fdc27](googleapis/java-spanner@37fdc27))

##### Bug Fixes

- Allow zero durations to be set for connections
([#&#8203;3916](googleapis/java-spanner#3916))
([43ea4fa](googleapis/java-spanner@43ea4fa))

##### Documentation

- Add snippet for Repeatable Read configuration at client and
transaction
([#&#8203;3908](googleapis/java-spanner#3908))
([ff3d212](googleapis/java-spanner@ff3d212))
- Update SpannerSample.java to align with best practices
([#&#8203;3625](googleapis/java-spanner#3625))
([7bfc62d](googleapis/java-spanner@7bfc62d))

</details>

<details>
<summary>googleapis/java-datastore
(com.google.cloud:google-cloud-datastore)</summary>

###
[`v2.30.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2300-2025-06-26)

##### Features

- Enable grpc configurator for client-side tracing
([#&#8203;1886](googleapis/java-datastore#1886))
([97004c8](googleapis/java-datastore@97004c8))

##### Dependencies

- Update dependency com.google.cloud:gapic-libraries-bom to v1.60.0
([#&#8203;1799](googleapis/java-datastore#1799))
([bf2a33c](googleapis/java-datastore@bf2a33c))
- Update dependency com.google.cloud:sdk-platform-java-config to v3.50.0
([#&#8203;1897](googleapis/java-datastore#1897))
([a8d99cd](googleapis/java-datastore@a8d99cd))
- Update googleapis/sdk-platform-java action to v2.59.1
([#&#8203;1880](googleapis/java-datastore#1880))
([4fb9929](googleapis/java-datastore@4fb9929))
- Update googleapis/sdk-platform-java action to v2.60.0
([#&#8203;1898](googleapis/java-datastore#1898))
([0921f86](googleapis/java-datastore@0921f86))

</details>

<details>
<summary>square/okio (com.squareup.okio:okio-fakefilesystem)</summary>

###
[`v3.14.0`](https://github.com/square/okio/blob/HEAD/CHANGELOG.md#Version-3140)

*2025-06-28*

- Upgrade: \[kotlinx-datetime 0.7.0]\[datetime\_0\_7\_0]. This impacts
the `okio-fakefilesystem`
artifact only. This is a binary-incompatible backwards-incompatible
change that cannot co-exist
with previous releases of `okio-fakefilesystem`! If you observe a
`NoSuchMethodError` calling
`FakeFileSystem.init`, update the calling code to this release (or
newer) and recompile. We don't
like imposing backwards-incompatible changes like this on you and do so
regretfully.

</details>

<details>
<summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary>

###
[`v1.50.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.50.1):
1.50.1

### Components

#### Build & Tooling

- ✨ Migrate publishing to Maven Central Portal
([#&#8203;9054](DataDog/dd-trace-java#9054) -
[@&#8203;sarahchen6](https://github.com/sarahchen6))

#### Trace context propagation

- 🐛 Drop Baggage when `TracePropagationBehaviorExtract=IGNORE`
([#&#8203;9052](DataDog/dd-trace-java#9052) -
[@&#8203;mhlidd](https://github.com/mhlidd))

#### Tracer public API

- 🐛 Fix ArrayIndexOutOfBoundsException in PercentEscaper
([#&#8203;9050](DataDog/dd-trace-java#9050) -
[@&#8203;mhlidd](https://github.com/mhlidd))

### Instrumentations

#### Akka instrumentation

- 🐛 Fix NPE in akka-http and pekko-http integrations
([#&#8203;9049](DataDog/dd-trace-java#9049) -
[@&#8203;mcculls](https://github.com/mcculls))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: e80867de3af2534eca79fe17a33f5c76801bcd6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakashanandg aakashanandg aakashanandg approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olavloite @aakashanandg @yoshi-kokoro