feat: Allow JDBC to configure directpath for connection #3927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
sakthivelmanii
commented
Jun 26, 2025
| @@ -1604,6 +1604,12 @@ public Builder disableLeaderAwareRouting() { | |||
| return this; | |||
| } | |||
|
|
|||
| @BetaApi | |||
There was a problem hiding this comment.
Since directpath is not public GA, I have marked as @BetaApi
sakthivelmanii
commented
Jun 26, 2025
| @@ -1000,7 +1000,7 @@ public static class Builder | |||
| private String compressorName; | |||
| private String emulatorHost = System.getenv("SPANNER_EMULATOR_HOST"); | |||
| private boolean leaderAwareRoutingEnabled = true; | |||
| private boolean attemptDirectPath = true; | |||
There was a problem hiding this comment.
Since this configuration wasn't used at all so far, I changed the default behaviour.
sakthivelmanii
force-pushed
the
provide_support_to_enable_directpath
branch
from
63ca2f2 to
9b0c7bc
Compare
olavloite
previously approved these changes
Jun 26, 2025
...le-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/ConnectionProperties.java
Outdated
Show resolved
Hide resolved
olavloite
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
chore: Allow JDBC to configure directpath for connection
END_COMMIT_OVERRIDE
Description:
Directpath allows GCP VM to connect to Spanner directly instead of going through public Google frontend. It improves the performance of the client library since all the requests are directly flowing to Spanner directly.
If client workload is deployed in non GCP VM, directpath will not work. it will fallback to connecting to Google public frondend.
In JDBC, we will be providing the support where customers can add the property
attemptDirectPath=truewhich will enable directpath for the connection.