Skip to content

Commit 060d17c

Browse files
committed
Fix lint
1 parent 2d074ba commit 060d17c

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

google/cloud/spanner_v1/pool.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ def get(self):
388388
span_event_attributes,
389389
)
390390
session = self._sessions.get_nowait()
391-
except queue.Empty as e:
391+
except queue.Empty:
392392
add_span_event(
393393
current_span,
394394
"No sessions available in pool. Creating session",
@@ -510,8 +510,9 @@ def bind(self, database):
510510
session_count=self.size - created_session_count,
511511
session_template=Session(creator_role=self.database_role),
512512
)
513-
span_event_attributes = {"kind": type(self).__name__}
514513

514+
span_event_attributes = {"kind": type(self).__name__}
515+
current_span = get_current_span()
515516
requested_session_count = request.session_count
516517
if requested_session_count <= 0:
517518
add_span_event(
@@ -521,7 +522,6 @@ def bind(self, database):
521522
)
522523
return
523524

524-
current_span = get_current_span()
525525
add_span_event(
526526
current_span,
527527
f"Requesting {requested_session_count} sessions",

tests/unit/test_pool.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -248,12 +248,12 @@ def test_spans_bind_get_empty_pool(self):
248248
pool = self._make_one(size=0)
249249
database = _Database("name")
250250
session1 = _Session(database)
251-
with trace_call("pool.Get", session1) as span:
251+
with trace_call("pool.Get", session1):
252252
try:
253253
pool.bind(database)
254254
database._sessions = database._sessions[:0]
255255
pool.get()
256-
except:
256+
except Exception:
257257
pass
258258

259259
wantEventNames = [

0 commit comments

Comments
 (0)