fix: remove requirement that cred aliases be alphanumeric (#580)

g-linville · web-flow · commit 549082a6cfed · 2024-06-27T17:32:08.000-04:00
Signed-off-by: Grant Linville &lt;grant@acorn.io&gt;
diff --git a/pkg/types/tool.go b/pkg/types/tool.go
@@ -5,7 +5,6 @@ import (
 	"encoding/json"
 	"fmt"
 	"path/filepath"
-	"regexp"
 	"slices"
 	"sort"
 	"strings"
@@ -284,10 +283,6 @@ func ParseCredentialArgs(toolName string, input string) (string, string, map[str
 		fields = fields[2:]
 	}
 
-	if alias != "" && !isAlphaNumeric(alias) {
-		return "", "", nil, fmt.Errorf("credential alias must be alphanumeric")
-	}
-
 	if len(fields) == 0 { // Nothing left, so just return
 		return originalName, alias, nil, nil
 	}
@@ -785,7 +780,3 @@ func FirstSet[T comparable](in ...T) (result T) {
 	}
 	return
 }
-
-func isAlphaNumeric(s string) bool {
-	return regexp.MustCompile(`^[a-zA-Z0-9_.]+$`).MatchString(s)
-}

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@ import (`
`5`	`5`	`"encoding/json"`
`6`	`6`	`"fmt"`
`7`	`7`	`"path/filepath"`
`8`		`- "regexp"`
`9`	`8`	`"slices"`
`10`	`9`	`"sort"`
`11`	`10`	`"strings"`
`@@ -284,10 +283,6 @@ func ParseCredentialArgs(toolName string, input string) (string, string, map[str`
`284`	`283`	`fields = fields[2:]`
`285`	`284`	`}`
`286`	`285`
`287`		`- if alias != "" && !isAlphaNumeric(alias) {`
`288`		`- return "", "", nil, fmt.Errorf("credential alias must be alphanumeric")`
`289`		`- }`
`290`		`-`
`291`	`286`	`if len(fields) == 0 { // Nothing left, so just return`
`292`	`287`	`return originalName, alias, nil, nil`
`293`	`288`	`}`
`@@ -785,7 +780,3 @@ func FirstSet[T comparable](in ...T) (result T) {`
`785`	`780`	`}`
`786`	`781`	`return`
`787`	`782`	`}`
`788`		`-`
`789`		`-func isAlphaNumeric(s string) bool {`
`790`		- return regexp.MustCompile(`^[a-zA-Z0-9_.]+$`).MatchString(s)
`791`		`-}`